Does a Reserve Other Than Honorable discharge effect benefits earned from Active Duty?

PO2 Joshua Lancaster - Short answer is that MSgt (Join to see) is correct. Your active duty discharge eligibility won't be affected by the character of your reserve component discharge.

Long Answer: The VA determines the eligibility by the period of service. If you have a qualifying eligibility based on an honorable period of service it is not 'negated' by a period of bad service (OTH, BCD, etc).

For example, if you enlisted, had honorable service, got out, reenlisted, injured while doing 'dishonorable service' and got a 'dishonorable' characterization on your discharge, you might not be able to claim disability benefits on the dishonorable period of service. However, you would still be able to claim educational benefits based on your honorable period of service from your first enlistment.

The VA's language on this is, "A discharge characterized by the military as under honorable conditions is binding on VA and allows for VA to provide benefits if other eligibility requirements are met." If you review the VA factsheet* regarding the character of discharge, they address this on page 3 for the question, "What if the individual in question had more than one period of active military service?".

The same is in your situation. You have honorable discharge from active duty but an other than honorable discharge from the reserves. Your period of service on active duty will establish eligibility, assuming you meet whatever other requirements a benefit might have, based on an honorable characterization. Your reserve component period of service will not affect it.
----------------------------------------------------------
* VA Fact sheet - Claims for VA Benefits and Character of Discharge - https://www.benefits.va.gov/BENEFITS/docs/COD_Factsheet.pdf
* https://www.swords-to-plowshares.org/guides/back-to-back-and-conditional-discharges

I believe an active duty discharge is not impacted by your subsequent reserve discharge. So you would be entitled to benefits, from the VA, based on your active duty service. But as LTC Eugene Chu mentioned you should contact JAG. They can advise you in any COA to take.

Edit:
After doing some reading it looks like the GI bill could be possibly locked to active duty time. But it is possible other benefits could be affected.

Yea, you could have benefits affected. What will (should) is somewhere in the process if the chapter, you should receive counseling stating what benefits you'll keep and lose based on the recommendations of your Commander. Now, the final approving authority will have final say for what is kept/lost. Also, you'll be afforded the opportunity to speak with a lawyer (JAG)