Should I give up on joining the Army for the really long wait and stay in school or should I just join?

Here is my two cents for what its worth:

You injured your foot, so you certainly don't want to come in with an injury and make it worse when you get to Basic. So, take the time to get that injury healed. Now, as for your other concerns, you can do one of several different COA's (Courses of Action):

1) Find a different recruiter. If the Recruiter is too busy to update you on your process, then perhaps find a different one.
2) Take the job. Perhaps try and join later after working a spell. This will help you with recovering from your injury and give you time to drop that weight.
3) You've invested this much time to get in, so take the opportunity to sign that contract.

Ultimately, the decision is yours. Go with what your gut instinct tells you. 99% of the time, that is the correct action. I still recommend you allow your injury to heal before you join, though. There is a plan in life for us. And some times that plan leads us in a different direction than what we thought it was going. If your path takes you away from the Army for a spell, then so be it. I'm certainly not saying to give up the idea of joining, just that fate seems to be telling you that it's going to be a bit longer before you can.

Johnathon Greer simple question. Do you want to be in the Army or not? If not, fine, I wish you well. If you do, then join. It's that simple. If you are working to where you want to be in life with your new vocation, great. The world needs skilled tradesmen. As far as your medical waiver process, that is not something that your recruiter can control. He is involved in initiation of it, but other wise out of his hands. He's getting dragged through broken glass on a monthly basis to put qualified and eligible recruits in boots. If it were up to him, he would have shipped you. He has to make thousands of contacts each month just to keep his head above water.

If you don't want to be a Soldier, I would not want you in my Company. This is a calling as much as a career. Do what you need to do.

I would look hard at where you will be in five years for both options. Then in 10. If you joined the Army and did what you were supposed to do, you'd be a NCO rank depending in your MOS, performance, ambition, and a few other factors. If you are an apprentice, you'll apprentice for a few years, then test for journeyman. You'll be a journeyman for a few more years until you have sufficient experience for your masters license. What will your benefits look like? What will your retirement look like? In the service the last two are fairly robust. Look hard at whether your civilian job has longevity or not or if you will be bouncing around contract to contract. Higher market wage may translate to future insecurity.

At the end of the day, it is about an individual choice, population: you.

Since you have a good job lined up, go National Guard! You can wait to ship out for up to a year, and your job is held for you by law.