Are groups like the American Legion and VFW too Right Wing Conservative for the new generation of Veterans?

The vast majority of military veterans I know are conservatives. as are the members of every VFW or AL post to which I have belonged. Our values center around patriotism and defending the American flag. It sounds like you are asking these organizations to apologize for that. We have a POS president who's been going around the world apologizing for America and what we've done throughout history. The VFW and the AL have nothing for which they should or ever will apologize. Nor will I ever apologize for idolizing the men of the Greatest Generation who accomplished the most dramatic history-changing task since the beginning of time. Those men are my heroes, as are all war veterans of this country.

If a bunch of 23-year-olds think that what the VFW and the AL stand for and what they do is irrelevant and antiquated, more power to them to start their own fraternity that's more socialistic and left wing.

Speaking strictly for the American Legion, I'd have to say the question "should not" apply. The American Legion prides itself on being non-partisan. Any time a politician speaks to Legionnaires at a Legion function or event they are told upfront and in no uncertain terms they need to address veteran issues and they cannot "stump" for election or re-election. Of course, we know that veterans (okay, especially "older" veterans) typically tend to lean a bit to the right side of the political spectrum, however, every program carried out by the American Legion is devoid of partisan politics and focus on Children and Youth, Veterans, Rehabilitation and National Security. The primary purpose of the Legion is stated in one of it's bylines "Still Serving America". The Legion serves America's veterans and their families, by fighting for veterans benefits and the adequate care for veterans and their families.

A number of years ago I had the privilege to be a team member on a community project sponsored by my employer to paint the American Legion building in our community. A handful of Legionnaires were on hand to provide some limited assistance as well as provide lunch for the volunteers.
I took the time to walk through their building and noted the fruits of their efforts displayed on their walls. The vast majority of those displays were reminders of the sacrifice made by WWII and Korean War Veterans. Some of these Veterans were young enough to have also serve during the Vietnam War.
I didn’t notice any specific endorsement of religion, however, I did notice a reverence to Christian values; which seem to be on par with what I see in the military today.
As we grow older the majority of us actually gain some wisdom, as well as a measure of regret over how we have conducted our lives. In the eyes and dialog of older Veterans I noticed they are quietly more interested in assisting the younger Veterans through the mine field of life than reliving the past. We are a very impatient generation and I think we need to sit back and not be so impatient with those we often consider out-of-date. In some cultures the old generation is held in high esteem and is given a wide berth of respect. This is often not true in our culture today. Consider one day you will be standing in their shoes. I say, joint the American Legion so that someday you may have the wisdom to address the concerns and issue you hold dear today.