If the United States required that all persons serve 1 term (2-4 years) in the Armed Forces, would that help or harm our society over time?

A handful of countries have or have had a policy similar to this (all males), I want to know how you think it would affect the United States and whether it should be all males or all persons.