When you have E-8s who are not in compliance with the regulations, is it OK to correct them on their appearance?

Let's see if I have this right. A pv2 with maybe three years under his belt is going to correct an E-8 ? Don't know about y'all , but back in my day if you did that you would have lowered the earth a few inches from all the push-ups.

I would stear away from correcting an senior NCO if I were you, Let the SGM and Officers deal with that. Focus on your career goals, E8s deal with senior officers and CSMs all day, so If they haven't said anything to correct them, I wouldn't neither. Just my personal advice.

My best advice: As a junior enlisted, I think you should focus on the unit mission. Build your technical skills to the highest level of excellence you can achieve. Be the soldier who is always in great physical condition, knows his job, and works hard to do things right every day. Ask questions when you don't understand something and learn leadership from your NCOs. Make this your full time Guard job and it won't matter if there are a few less-than-professional SNCOs in your unit.

My experience with the Guard tells me personal relationships are more intense in the Guard because people don't PCS in and out all the time. Friendships run deep and interpersonal relationships may ignore rank or position. The SNCOs in you organization have probably been there since the turn of the Century, or longer. They have the internal formal and informal leadership network in their hands. They can make your life miserable in so many ways you don't event know about yet. You may be better off to ignore the jacked-up-ness of the SNCOs. However (there's always a "however") if the jacked-up condition threatens the health, safety, or mission accomplishment of any person or organization, then you need to bring it to the attention of the first NCO in your chain of command.

It's important to do right-just make sure you're doing it for the right reasons, not as some revenge trip. But regardless of the purity of your reasons for doing so, make double-damn sure you're correct to begin with, then be tactful and business-like.

If they are in the wrong, hopefully--if they are leaders of solid character--they will appreciate what you did.

jacked up in what way?

You BEST be %100 sure before you do it !!!!

Some of the things I see in the ARNG gives me grey hair...

What is this nonsense if a private thinks it's ok to correct a SNCO. As long as you do it with Tact and not go up there and say hey 1sg you are all fucked up, you should be fine. We as an Army should be squaring each other away, no matter the rank. You wouldn't want you Battalion Commander walking around with their boot laces out, would you. As long as you show respect and don't call them out in public, they should have no problem and might actually thank you. i saw this one guy get promoted to sergeant and have the wrong US flag on and no one said anything.

Yes it is ok, but make sure you are a 100% correct and be diplomatic. However, be ready that even if you are correct and diplomatic, you could still get some blowback. pick your battles wisely.

Lots of great answers here. Make sure you are using professionalism and tact. Also make sure you aren't doing it in front of their peers, subordinates or superiors.